Remove Dialyzer-specific problem matcher #182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out this problem matcher is a little too loose, which causes it to match things it shouldn't. Noticed in this CI run, it will match timestamps in JSON. This can be seen if you run the common
docker/setup-buildx-action@v2
(among others):Which would result in the last two lines being detected and a
warning
annotation on the last line:Instead, it's recommended to run
mix dialyzer --format github
which will use a special GitHub actions log format to create warning annotations. This has the advantage of not being triggered for random log text. Running locally should output something like:Default output for comparison:
More information from the upstream PR: jeremyjh/dialyxir#463